gh-105042: Disable unmatched parens syntax error in python tokenize#105061
Merged
pablogsal merged 3 commits intopython:mainfrom May 30, 2023
Merged
gh-105042: Disable unmatched parens syntax error in python tokenize#105061pablogsal merged 3 commits intopython:mainfrom
pablogsal merged 3 commits intopython:mainfrom
Conversation
pablogsal
reviewed
May 30, 2023
Member
|
We also need a bunch of tests that cover these, one in the |
pablogsal
reviewed
May 30, 2023
pablogsal
reviewed
May 30, 2023
lysnikolaou
force-pushed
the
tokenize-unmatched-parens
branch
from
049da25 to
ed1237a
Compare
Member
Author
|
@pablogsal This is ready for another review. |
Member
Can you add a couple of tests for this? Maybe something on these lines: #105042 (comment) in the inspect module here: cpython/Lib/test/test_inspect.py Line 779 in 0656d23 |
Member
Author
|
@pablogsal Thanks for the reminder! Tests added in c7481a5. |
Contributor
|
Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2023
…nize (pythonGH-105061) (cherry picked from commit 70f315c) Co-authored-by: Lysandros Nikolaou <[email protected]>
|
GH-105120 is a backport of this pull request to the 3.12 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.